fix: improve HTML content handling in algoliaSplitter.js #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored `splitHtmlContent` to enhance section trimming and ensure empty sections are properly handled. - Updated `removeIgnoredContent` to correctly remove multiline content within ignored tags and self-closing tags. - Added a new test case to verify removal of content inside multiline `<area>` tags.
sbellone
reviewed
Jan 15, 2025
Comment on lines
34
to
36
| section = StringUtils.trim(splitterBegin + section) || ''; | ||
|
|
||
| if (!section.trim()) { | ||
| if (!section) { |
There was a problem hiding this comment.
section can't be undefined: splitterBegin is initialized manually at the beginning of the function.
| new RegExp('<' + tag + '[^>]*>[\\s\\S]*?<\\/' + tag + '>', 'gi'), | ||
| '' | ||
| ); | ||
| // Remove self-closing tags <tag ... /> |
There was a problem hiding this comment.
Good, I think this addresses this comment thanks: https://github.com/algolia/algoliasearch-sfcc-b2c/pull/164/files#r1565893249
Please add unit tests on the removeIgnoredContent function directly to confirm, including tests with self-closing tags.
- Expanded unit tests in `algoliaSplitter.test.js` to cover various scenarios for the new function, ensuring robust handling of ignored tags and preserving relevant content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is Changed
splitHtmlContentto enhance section trimming and ensure empty sections are properly handled.removeIgnoredContentto correctly remove multiline content within ignored tags and self-closing tags.