Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Add support for minMatchingChars=0 #40

Closed
wants to merge 21 commits into from
Closed

Conversation

jhalag
Copy link

@jhalag jhalag commented Mar 5, 2019

Allow displaying the list on initial select if minMatchingChars==0

Resolves #39

@coveralls
Copy link

coveralls commented Mar 5, 2019

Pull Request Test Coverage Report for Build 60

  • 40 of 44 (90.91%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.4%) to 74.83%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/VueBootstrapTypeaheadList.vue 34 35 97.14%
src/components/VueBootstrapTypeahead.vue 1 4 25.0%
Totals Coverage Status
Change from base Build 38: 5.4%
Covered Lines: 69
Relevant Lines: 94

💛 - Coveralls

(add watch & initial value, null fixes awaiting PR in alexurquhart 
repository)
@isaacmillercodes
Copy link

Any word on when this might be merged in? I could use this for a project I'm working on. Thanks!

@Lobidu
Copy link

Lobidu commented Mar 20, 2019

+1

jhalag added 3 commits April 15, 2019 14:30
Addition of keyup event emitter, and ability to setFocus() on the 
contained input field.

Adjust logic when minMatchingChars==0 to allow for null, undefined, 0 
length string
Adjusted CountrySearch demo to use minMatchingChars=0

Rebuild of dist/ directory
@jhalag
Copy link
Author

jhalag commented Apr 15, 2019

I do not intend to take over maintenance of the project, but if anyone needs a version that has this fix, as well as #32 and #29 merged it is available on my fork. (FYI: there are additional changes present which I have made for my own project's use)

@jhalag
Copy link
Author

jhalag commented Apr 15, 2019

Closing PR, creating new one off correct branch

@mattzollinhofer
Copy link

If anyone stumbles across this PR. I am attempting to maintain this project, but had to fork it to here: https://github.com/mattzollinhofer/vue-typeahead-bootstrap.

I merged in functionality that I think meets this need here: mattzollinhofer/vue-typeahead-bootstrap@09a6cf7. This implementation refers to it as showOnFocus rather than re-using minMatchingChars but I believe the outcome is essentially the same unless I'm not understanding.

You can use the functionality under the forked project: https://www.npmjs.com/package/vue-typeahead-bootstrap or https://github.com/mattzollinhofer/vue-typeahead-bootstrap.

Hope this helps anyone who needs this functionality going forward!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option: Show all on initial focus event
8 participants