Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web-seed(s) to magnet link #186

Merged
merged 7 commits into from
Mar 22, 2024
Merged

Add web-seed(s) to magnet link #186

merged 7 commits into from
Mar 22, 2024

Conversation

nitronarcosis
Copy link
Contributor

I think this is all that's needed to add web seeds to magnet links.
Not tested because I don't understand Python packaging yet.

@alexpdev
Copy link
Owner

alexpdev commented Dec 18, 2023 •
edited
Loading

Please include a unit test for the code.

alexpdev
alexpdev reviewed Dec 18, 2023
View reviewed changes
torrentfile/commands.py Outdated Show resolved Hide resolved
alexpdev
alexpdev reviewed Dec 18, 2023
View reviewed changes
torrentfile/commands.py Outdated Show resolved Hide resolved
alexpdev
alexpdev requested changes Dec 18, 2023
View reviewed changes
Copy link
Owner

@alexpdev alexpdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, there are number of issues with your code. Including invalid variables and code that will lead to errors and exceptions in most cases.

This is why you should always include a unit-test with submitted PR's

@alexpdev alexpdev added the invalid This doesn't seem right label Dec 18, 2023
@nitronarcosis
Fix variable name and attempt to write tests
217f12b
@nitronarcosis
Remove whitespace from line
7129677
@nitronarcosis
Fix web seeds
6820dae 
I think this works for a single entry, not sure about multiple or a list
@alexpdev alexpdev self-requested a review December 22, 2023 07:20
@alexpdev alexpdev added enhancement New feature or request and removed invalid This doesn't seem right labels Dec 28, 2023
alexpdev
alexpdev requested changes Dec 28, 2023
View reviewed changes
Copy link
Owner

@alexpdev alexpdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a single line that needs modification before testing can resume.

alexpdev added 2 commits March 21, 2024 23:36
@alexpdev
Update test_commands.py
d883089 
removed superfluous test and modified another for it to work properly.
@alexpdev
Update commands.py
5030b48 
Removed 2 subbranches in order to pass cyclomancy test
@alexpdev alexpdev merged commit 4059abf into alexpdev:master Mar 22, 2024
0 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpdev alexpdev alexpdev approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitronarcosis @alexpdev