crf-search: 2nd iteration 20/80 & disable on small min/max crf ranges #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2nd iter logic is a bit arcane and not at all obvious to the user. In future this should probably be configurable.
Relates to discussions in #227, #232
Example
So for default settings:
The slight widening means more searches will get to linear interpolation on 3rd iter (those that 21 would have failed on). Though those 21 would have passed on will have slightly worse linear interpolated guess for 3rd iter.
The ones that still fail at 19 will continue to next try min-crf=10, but will benefit slightly on 4th iter with slightly tighter range to interpolate inside.