-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --keep
flag to crf-search
subcommand
#166
Conversation
2730ed2
to
b1e51e7
Compare
Btw: what is the double purpose of cleaning in main() and sample_encode::run |
Thanks, I 'm ok with crf-search & auto-encode having
Yes I think that makes sense.
Early cleaning keeps storage usage ceiling down. Cleaning at the end is required to handle ctrl-c interrupts & anything left over. |
a557b3c
to
f557d4e
Compare
Should be fine now :) |
Looks good now, just one minor code comment. Can you pop something in the changelog? |
c4d7128
to
4b65084
Compare
598718d
to
53da1bb
Compare
Thanks! |
For me it's very useful to look at the generated samples for manual verification. This command works on my machine right now.
@alexheretic please tell me if you want the flag refactored into
args::Sample
. Its probably better that way, right?