Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bright colors variants #55

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

MHase
Copy link
Contributor

@MHase MHase commented Aug 15, 2023

Bright colors variants as mentioned in #47 😄
Also added few empty lines separating colors group for easier navigating through the code

@MHase MHase force-pushed the feat/bright-colors-variants branch from 658a2ae to 92e88c2 Compare August 15, 2023 17:03
@MrFoxPro
Copy link

Is it possible to add orange color?

@MHase
Copy link
Contributor Author

MHase commented Aug 30, 2023

@MrFoxPro absolutely I can contribute to that :) but this PR focus only on adding corresponding/existing colors in bright variants. if that will/would be accepted then I can proceed in adding something more 👍🏻

@WaldoJeffers
Copy link

Thanks for your work @MHase
Any chance of seeing this merged?
I feel it would really help people who are migrating from chalk -> picocolors

Or are there any issues with the PR, or the impact it would have on the overall size?

@MHase
Copy link
Contributor Author

MHase commented Dec 13, 2023

@WaldoJeffers I would love to see this merged, but we need someone to approve/merge this PR for us
Only those with write access to this repository can merge pull requests.

Any idea who we can ping to move this forward?

@MrFoxPro
Copy link

@alexeyraspopov

@jaclas
Copy link

jaclas commented Feb 2, 2024

Still not approved? What is it about? I also need "bright" colors.
@marco-carvalho @borodean @alexeyraspopov ?

@MHase
Copy link
Contributor Author

MHase commented Feb 2, 2024

based on responses it looks like this repo was abandoned...

@jaclas
Copy link

jaclas commented Feb 2, 2024

15 million projects use this module, maybe someone will take it further...

@alexeyraspopov
Copy link
Owner

The library is mostly used indirectly, by other more significant projects. I appreciate the PRs and will get back to them as soon as I got time, but I can’t just prioritize PRs that start bloating the size for little to no benefit.

Thanks

@jaclas
Copy link

jaclas commented Feb 4, 2024

@alexeyraspopov Thanks for showing up!
This PR increases the size by just a few hundred bytes, in return doubles the number of available colors. And most importantly, it fulfills the promise of easy migration from Chalk, where *Bright colors are present.

@43081j
Copy link

43081j commented Jun 18, 2024

@alexeyraspopov any chance we can get these bright colours over the line?

As part of the ecosystem cleanup effort I'm leading, we're replacing chalk & others with picocolours in many popular repos. The only missing thing that all other alternatives have seems to be these variants

If you need any help maintaining this too, let me know. I would be happy to help, especially given I'm making quite a few large packages depend on it

@43081j
Copy link

43081j commented Jun 18, 2024

@MHase can you possibly catch this up from main? The fallback logic was refactored since, so there's probably some conflicts

@MHase MHase force-pushed the feat/bright-colors-variants branch from 92e88c2 to bfae657 Compare June 25, 2024 07:18
@MHase
Copy link
Contributor Author

MHase commented Jun 25, 2024

@43081j done ✅

@alexeyraspopov alexeyraspopov merged commit 1d7a86d into alexeyraspopov:main Jun 25, 2024
7 of 8 checks passed
@WuglyakBolgoink
Copy link

Hallo @MHase / @alexeyraspopov !

but this PR was not published on npm? correct?

@MHase
Copy link
Contributor Author

MHase commented Jul 14, 2024

@WuglyakBolgoink unfortunately correct
the latest release was on 14 May with version 1.0.1

@trivikr
Copy link

trivikr commented Jul 15, 2024

@alexeyraspopov When is this expected to be published?
Is it going to be in 1.1.0 or 1.0.2?

@alexeyraspopov
Copy link
Owner

I will publish 1.1.0 once #71 is resolved

@trivikr
Copy link

trivikr commented Jul 15, 2024

@alexeyraspopov Can you publish 1.0.2 with this fix in the meantime to unblock migrations from chalk?


I just posted a PR to migrate from chalk to picocolors in changesets changesets/changesets#1417
The maintainers have not reviewed it at the time of comment, but there's a possibility they might block it because of the absence of redBright API.

I also posted migrations requests on popular repos, where maintainers seem to be onboard at the time of comment:

@kravetsone
Copy link

I will publish 1.1.0 once #71 is resolved

we need this( please publish it in 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants