-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bright colors variants #55
feat: bright colors variants #55
Conversation
658a2ae
to
92e88c2
Compare
Is it possible to add orange color? |
@MrFoxPro absolutely I can contribute to that :) but this PR focus only on adding corresponding/existing colors in bright variants. if that will/would be accepted then I can proceed in adding something more 👍🏻 |
Thanks for your work @MHase Or are there any issues with the PR, or the impact it would have on the overall size? |
@WaldoJeffers I would love to see this merged, but we need someone to approve/merge this PR for us Any idea who we can ping to move this forward? |
Still not approved? What is it about? I also need "bright" colors. |
based on responses it looks like this repo was abandoned... |
15 million projects use this module, maybe someone will take it further... |
The library is mostly used indirectly, by other more significant projects. I appreciate the PRs and will get back to them as soon as I got time, but I can’t just prioritize PRs that start bloating the size for little to no benefit. Thanks |
@alexeyraspopov Thanks for showing up! |
@alexeyraspopov any chance we can get these bright colours over the line? As part of the ecosystem cleanup effort I'm leading, we're replacing chalk & others with picocolours in many popular repos. The only missing thing that all other alternatives have seems to be these variants If you need any help maintaining this too, let me know. I would be happy to help, especially given I'm making quite a few large packages depend on it |
@MHase can you possibly catch this up from main? The fallback logic was refactored since, so there's probably some conflicts |
92e88c2
to
bfae657
Compare
@43081j done ✅ |
Hallo @MHase / @alexeyraspopov ! but this PR was not published on npm? correct? |
@WuglyakBolgoink unfortunately correct |
@alexeyraspopov When is this expected to be published? |
I will publish |
@alexeyraspopov Can you publish I just posted a PR to migrate from I also posted migrations requests on popular repos, where maintainers seem to be onboard at the time of comment: |
we need this( please publish it in |
##### [`v1.1.0](https://github.com/alexeyraspopov/picocolors/blob/HEAD/CHANGELOG.md#v110) - Added bright color variants ([#55](alexeyraspopov/picocolors#55))
Bright colors variants as mentioned in #47 😄
Also added few empty lines separating colors group for easier navigating through the code