Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rclone, kubie & EKS-node-viewer #1131

Merged
merged 1 commit into from
Nov 6, 2024
Merged

feat: add rclone, kubie & EKS-node-viewer #1131

merged 1 commit into from
Nov 6, 2024

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Nov 5, 2024 •
edited
Loading

Description

Adds the following tools to take the number of tools provided to 162:

  • rclone
  • kubie
  • eks-node-viewer

Motivation and Context

How Has This Been Tested?

Functional

  • kubie
➜  arkade git:(addMiscTools) ✗ ./arkade get kubie            
Downloading: kubie
2024/11/05 21:25:52 Looking up version for kubie
2024/11/05 21:25:52 Found: v0.24.0
Downloading: https://github.com/sbstp/kubie/releases/download/v0.24.0/kubie-darwin-arm64
3.79 MiB / 3.79 MiB [-----------------------------------------------------------------] 100.00%
/var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-2227642659/kubie-darwin-arm64 written.
2024/11/05 21:25:54 Copying /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-2227642659/kubie-darwin-arm64 to /Users/rgee0/.arkade/bin/kubie

Wrote: /Users/rgee0/.arkade/bin/kubie (3.97MB)

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/Users/rgee0/.arkade/bin/kubie

# Or install with:
sudo mv /Users/rgee0/.arkade/bin/kubie /usr/local/bin/

👏 Say thanks for arkade and sponsor Alex via GitHub: https://github.com/sponsors/alexellis
  • rclone
➜  arkade git:(addMiscTools) ✗ ./arkade get rclone
Downloading: rclone
2024/11/05 21:26:00 Looking up version for rclone
2024/11/05 21:26:00 Found: v1.68.1
Downloading: https://github.com/rclone/rclone/releases/download/v1.68.1/rclone-v1.68.1-osx-arm64.zip
22.94 MiB / 22.94 MiB [---------------------------------------------------------------] 100.00%
/var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-1268097866/rclone-v1.68.1-osx-arm64.zip written.
Name: rclone-v1.68.1-osx-arm64.zip, size: 240561502024/11/05 21:26:04 Extracted: /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-1268097866/rclone
2024/11/05 21:26:04 Copying /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-1268097866/rclone to /Users/rgee0/.arkade/bin/rclone

Wrote: /Users/rgee0/.arkade/bin/rclone (66.74MB)

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/Users/rgee0/.arkade/bin/rclone

# Or install with:
sudo mv /Users/rgee0/.arkade/bin/rclone /usr/local/bin/

👏 Say thanks for arkade and sponsor Alex via GitHub: https://github.com/sponsors/alexellis
  • eks-node-viewer
➜  arkade git:(addMiscTools) ✗ ./arkade get eks-node-viewer
Downloading: eks-node-viewer
2024/11/05 21:26:11 Looking up version for eks-node-viewer
2024/11/05 21:26:11 Found: v0.7.0
Downloading: https://github.com/awslabs/eks-node-viewer/releases/download/v0.7.0/eks-node-viewer_Darwin_all
106.76 MiB / 106.76 MiB [-------------------------------------------------------------] 100.00%
/var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-2747148913/eks-node-viewer_Darwin_all written.
2024/11/05 21:26:21 Copying /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-2747148913/eks-node-viewer_Darwin_all to /Users/rgee0/.arkade/bin/eks-node-viewer

Wrote: /Users/rgee0/.arkade/bin/eks-node-viewer (111.9MB)

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/Users/rgee0/.arkade/bin/eks-node-viewer

# Or install with:
sudo mv /Users/rgee0/.arkade/bin/eks-node-viewer /usr/local/bin/

👏 Say thanks for arkade and sponsor Alex via GitHub: https://github.com/sponsors/alexellis

make e2e

➜  arkade git:(addMiscTools) ✗ make e2e >> test.out
CGO_ENABLED=0 go test github.com/alexellis/arkade/pkg/get -cover --tags e2e -v
...
PASS
coverage: 61.8% of statements
ok  	github.com/alexellis/arkade/pkg/get	15.387s	coverage: 61.8% of statements

./hack/test_tool

  • kubie (windows not supported)
➜  arkade git:(addMiscTools) ✗ ./hack/test-tool.sh kubie
+ ./arkade get kubie --arch arm64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/kubie
/Users/rgee0/.arkade/bin/kubie: Mach-O 64-bit executable arm64
+ rm /Users/rgee0/.arkade/bin/kubie
+ echo

+ ./arkade get kubie --arch x86_64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/kubie
/Users/rgee0/.arkade/bin/kubie: Mach-O 64-bit executable arm64
+ rm /Users/rgee0/.arkade/bin/kubie
+ echo

+ ./arkade get kubie --arch x86_64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/kubie
/Users/rgee0/.arkade/bin/kubie: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, BuildID[sha1]=ca04ce976382dc530448adc9662435069389bd9a, stripped
+ rm /Users/rgee0/.arkade/bin/kubie
+ echo

+ ./arkade get kubie --arch aarch64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/kubie
/Users/rgee0/.arkade/bin/kubie: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, stripped
+ rm /Users/rgee0/.arkade/bin/kubie
+ echo

+ ./arkade get kubie --arch x86_64 --os mingw --quiet

The requested version of kubie is not available or configured in arkade for mingw/x86_64

* Check if a binary is available from the project for your Operating System
* View the kubie releases page: https://github.com/sbstp/kubie/releases
* Feel free to raise an issue at https://github.com/alexellis/arkade/issues for help

Error: server returned status: 404
  • rclone
➜  arkade git:(addMiscTools) ✗ ./hack/test-tool.sh rclone
+ ./arkade get rclone --arch arm64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/rclone
/Users/rgee0/.arkade/bin/rclone: Mach-O 64-bit executable arm64
+ rm /Users/rgee0/.arkade/bin/rclone
+ echo

+ ./arkade get rclone --arch x86_64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/rclone
/Users/rgee0/.arkade/bin/rclone: Mach-O 64-bit executable x86_64
+ rm /Users/rgee0/.arkade/bin/rclone
+ echo

+ ./arkade get rclone --arch x86_64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/rclone
/Users/rgee0/.arkade/bin/rclone: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=D7uA7INE8Yu4aV2kX5O-/Er7al-dDPx57y1hXgGjc/beNdJtyy4UP8ep0uem1G/6A9QZ12g6GBGE4LKTA28, stripped
+ rm /Users/rgee0/.arkade/bin/rclone
+ echo

+ ./arkade get rclone --arch aarch64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/rclone
/Users/rgee0/.arkade/bin/rclone: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=Wq_molbcTdQCddxJtp0l/mrWy6UgkyiOXI7WobktT/ZB3nvqYdLH5Gvs26m8QI/eLh0tpQUa5bz7ta3jjYH, stripped
+ rm /Users/rgee0/.arkade/bin/rclone
+ echo

+ ./arkade get rclone --arch x86_64 --os mingw --quiet
+ file /Users/rgee0/.arkade/bin/rclone.exe
/Users/rgee0/.arkade/bin/rclone.exe: PE32+ executable (console) x86-64, for MS Windows
+ rm /Users/rgee0/.arkade/bin/rclone.exe
+ echo
  • eks-node-viewer (effect of Darwin_all visible)
➜  arkade git:(addMiscTools) ✗ ./hack/test-tool.sh eks-node-viewer
+ ./arkade get eks-node-viewer --arch arm64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/eks-node-viewer
/Users/rgee0/.arkade/bin/eks-node-viewer: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64]
/Users/rgee0/.arkade/bin/eks-node-viewer (for architecture x86_64):     Mach-O 64-bit executable x86_64
/Users/rgee0/.arkade/bin/eks-node-viewer (for architecture arm64):      Mach-O 64-bit executable arm64
+ rm /Users/rgee0/.arkade/bin/eks-node-viewer
+ echo

+ ./arkade get eks-node-viewer --arch x86_64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/eks-node-viewer
/Users/rgee0/.arkade/bin/eks-node-viewer: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64]
/Users/rgee0/.arkade/bin/eks-node-viewer (for architecture x86_64):     Mach-O 64-bit executable x86_64
/Users/rgee0/.arkade/bin/eks-node-viewer (for architecture arm64):      Mach-O 64-bit executable arm64
+ rm /Users/rgee0/.arkade/bin/eks-node-viewer
+ echo

+ ./arkade get eks-node-viewer --arch x86_64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/eks-node-viewer
/Users/rgee0/.arkade/bin/eks-node-viewer: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=YwVipux9bF9f60KYPdr1/cWZHIUP3-XgBcw1LkTIP/PjcZ3QdVX3o5VH-yZmtY/XXEoEPWu7iuvuV71nGF_, stripped
+ rm /Users/rgee0/.arkade/bin/eks-node-viewer
+ echo

+ ./arkade get eks-node-viewer --arch aarch64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/eks-node-viewer
/Users/rgee0/.arkade/bin/eks-node-viewer: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=W5U6qRoUhxBgqql0oMVG/_0PEyNlfKDZ4vKCY5vt8/P6jEy7zed95Won1hx-9l/2aTOFd2KHsApDR_53mTK, stripped
+ rm /Users/rgee0/.arkade/bin/eks-node-viewer
+ echo

+ ./arkade get eks-node-viewer --arch x86_64 --os mingw --quiet
+ file /Users/rgee0/.arkade/bin/eks-node-viewer.exe
/Users/rgee0/.arkade/bin/eks-node-viewer.exe: PE32+ executable (console) x86-64, for MS Windows
+ rm /Users/rgee0/.arkade/bin/eks-node-viewer.exe
+ echo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

alexellis
alexellis approved these changes Nov 6, 2024
View reviewed changes
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit b0cf2fb into alexellis:master Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis alexellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rclone as a tool Add kubie to TOOLS
2 participants
@rgee0 @alexellis