Ignore latest tags in chart upgrade #1087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #1086 the
chart upgrade
command was upgradinglatest
tags which was undesirable.This change causes the upgrade command to ignore any images tagged
latest
.It also addresses an edge-case around
-RC
tags which was highlighted by the additional test created in this change.The k10mulitcluster tool that was disabled has also been removed, so closes #1082
Motivation and Context
design/approved
by a maintainerFixes Don't upgrade latest tag via chart upgrade command #1086
How Has This Been Tested?
Functionally tested by using the faasd
docker-compose.yaml
.Initially ran
chart upgrade
on the file as is, and one change was found:➜ arkade git:(ignoreLatest) ✗ ./arkade chart upgrade -f faasd.yaml -v 2024/06/13 09:37:33 Verifying images in: faasd.yaml 2024/06/13 09:37:33 Found 4 images 2024/06/13 09:37:34 [ghcr.io/openfaas/gateway] 0.27.5 => 0.27.7
This image was then changed to
ghcr.io/openfaas/gateway:latest
and the command run again:The new test passes as show in the pipeline
No new tool has been added.
Types of changes
Documentation
./arkade get --format markdown
./arkade install --help
Checklist:
git commit -s