Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a 'NotProvided' solution state to the SolutionState enum #29

Merged

Conversation

thisisparker
Copy link
Contributor

This is not well documented but one of the values in the SolutionState bit at 0x32 is 0x0002, which indicates that the solution is not present in the file. In practice I think almost every client treats it just about the same as 0x0004 in that spot (suppressing or disabling "reveal" tools) but it may be the case that some clients will correctly not offer an attempt to unscramble either.

@alexdej
Copy link
Owner

alexdej commented Jun 12, 2024

Thanks for this @thisisparker . Have you encountered a puzzle in the wild that does not provide a solution? Would be nice to add to tests. thx

@alexdej alexdej merged commit 6083384 into alexdej:master Jun 12, 2024
5 checks passed
@thisisparker
Copy link
Contributor Author

I have created puzzles that have this bit set, and testers have confirmed that it does lead to some "expected" different behavior in e.g. Across Lite — in particular, as I mentioned above, the "reveal" options are not provided, and the completion screen expresses some uncertainty about whether you've completed the puzzle. For that to work, though, the solution bits still needed to be filled, and I did so with Xes as is conventional.

Happy to share one such puzzle if it would help for testing! But I didn't really encounter it in the wild. To be honest I was surprised to learn about this SolutionState before opening this issue.

@royleban
Copy link

royleban commented Jun 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants