Skip to content

Commit

Permalink
Fixes visuals of unsupported serving runtime message to match mocks
Browse files Browse the repository at this point in the history
  • Loading branch information
alexcreasy committed Jun 12, 2024
1 parent 95c5fdd commit c29c877
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ describe.only('KServe performance metrics', () => {
modelMetricsKserve.findInvalidDefinitionError().should('be.visible');
});

it.only('should display 2 graphs with the given config', () => {
it('should display 2 graphs with the given config', () => {
initIntercepts({
disableBiasMetrics: false,
disablePerformanceMetrics: false,
Expand Down
17 changes: 13 additions & 4 deletions frontend/src/concepts/metrics/kserve/KserveMetricsContext.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import * as React from 'react';
import {
Bullseye,
EmptyState,
EmptyStateBody,
EmptyStateHeader,
EmptyStateIcon,
PageSectionVariants,
Spinner,
Expand Down Expand Up @@ -109,10 +111,17 @@ export const KserveMetricsContextProvider = conditionalArea<KserveMetricsContext
if (!supported) {
return (
<EmptyState>
<EmptyStateIcon icon={CubesIcon} />
<Title headingLevel="h4" size="lg" data-testid="kserve-metrics-runtime-unsupported">
Metrics are unsupported for this serving runtime.
</Title>
<EmptyStateHeader
data-testid="kserve-metrics-runtime-unsupported"
titleText="Metrics not supported"
headingLevel="h4"
icon={<EmptyStateIcon icon={CubesIcon} />}
/>
<EmptyStateBody>
{modelName} is using a custom serving runtime. Metrics are only supported for models
served via a pre-installed runtime when the single-model serving platform is enabled for a
project.
</EmptyStateBody>
</EmptyState>
);
}
Expand Down

0 comments on commit c29c877

Please sign in to comment.