WIP more tests

alexcreasy · Jun 12, 2024 · 8e5a181 · 8e5a181
1 parent 9a88ce9
commit 8e5a181
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 16 deletions.
diff --git a/frontend/src/__tests__/cypress/cypress/pages/modelMetrics.ts b/frontend/src/__tests__/cypress/cypress/pages/modelMetrics.ts
@@ -47,6 +47,10 @@ class ModelMetricsKserve extends ModelMetricsPerformance {
     return cy.findByTestId('kserve-configmap-error');
   }
 
+  findKserveAreasDisabledCard() {
+    return cy.findByTestId('kserve-metrics-disabled');
+  }
+
   findUnsupportedRuntimeCard() {
     return cy.findByTestId('kserve-metrics-runtime-unsupported');
   }

diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/modelServing/modelMetrics.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/modelServing/modelMetrics.cy.ts
@@ -621,8 +621,8 @@ describe('Model Metrics', () => {
   });
 });
 
-describe.only('KServe performance metrics', () => {
-  it.only('should show not found when area disabled', () => {
+describe('KServe performance metrics', () => {
+  it('should inform user when area disabled', () => {
     initIntercepts({
       disableBiasMetrics: false,
       disablePerformanceMetrics: false,
@@ -632,7 +632,7 @@ describe.only('KServe performance metrics', () => {
       inferenceServices: [mockInferenceServiceK8sResource({ isModelMesh: false })],
     });
     modelMetricsKserve.visit('test-project', 'test-inference-service');
-    modelMetricsKserve.findConfigMapErrorCard().should('be.visible');
+    modelMetricsKserve.findKserveAreasDisabledCard().should('be.visible');
   });
 
   it('should show error when ConfigMap is missing', () => {

diff --git a/frontend/src/pages/modelServing/screens/metrics/performance/PerformanceTab.tsx b/frontend/src/pages/modelServing/screens/metrics/performance/PerformanceTab.tsx
@@ -22,19 +22,19 @@ const PerformanceTab: React.FC<PerformanceTabsProps> = ({ model }) => {
   const modelMesh = isModelMesh(model);
   const kserveMetricsEnabled = useIsAreaAvailable(SupportedArea.K_SERVE_METRICS).status;
 
-  // if (!modelMesh && !kserveMetricsEnabled) {
-  //   return (
-  //     <EmptyState variant="full">
-  //       <EmptyStateHeader
-  //         titleText="Single-model serving platform model metrics are not enabled."
-  //         headingLevel="h4"
-  //         icon={<EmptyStateIcon icon={WarningTriangleIcon} />}
-  //         alt=""
-  //         data-testid="kserve-metrics-disabled"
-  //       />
-  //     </EmptyState>
-  //   );
-  // }
+  if (!modelMesh && !kserveMetricsEnabled) {
+    return (
+      <EmptyState variant="full">
+        <EmptyStateHeader
+          titleText="Single-model serving platform model metrics are not enabled."
+          headingLevel="h4"
+          icon={<EmptyStateIcon icon={WarningTriangleIcon} />}
+          alt=""
+          data-testid="kserve-metrics-disabled"
+        />
+      </EmptyState>
+    );
+  }
 
   return (
     <Stack data-testid="performance-metrics-loaded">