Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated testing pipeline #21

Merged
merged 13 commits into from
Aug 14, 2024
Merged

Conversation

j-i-l
Copy link
Collaborator

@j-i-l j-i-l commented Aug 7, 2024

The goal is to have a github workflow set up that:

  1. builds the package
  2. installs it
  3. finds and runs all tests in the tests/ folder
  4. checks linting of the codebase

This workflow should run on all pull requests (to main) and on any change to main itself.

Optionally, we can then enforce that only pull requests for which this workflow succeeds can be merged.
However, for now we are quite fare from a lint code-base, so this restriction will be for later.

@j-i-l j-i-l linked an issue Aug 7, 2024 that may be closed by this pull request
@j-i-l j-i-l force-pushed the 13-cicd-setup-for-automated-testing branch from e7dc205 to 0c2529d Compare August 12, 2024 06:39
@j-i-l j-i-l force-pushed the 13-cicd-setup-for-automated-testing branch from 99c5846 to 7371799 Compare August 12, 2024 08:34
@j-i-l j-i-l self-assigned this Aug 14, 2024
@j-i-l j-i-l force-pushed the 13-cicd-setup-for-automated-testing branch from 0a9322c to 90edaa1 Compare August 14, 2024 10:56
@j-i-l j-i-l marked this pull request as ready for review August 14, 2024 11:01
@j-i-l j-i-l requested a review from alexbovet August 14, 2024 11:09
@j-i-l
Copy link
Collaborator Author

j-i-l commented Aug 14, 2024

@alexbovet This will introduce automated testing and linting on pull requests (see description above).

For now the linter complains about quite a few things, but I'd suggest we address them in a different pull request. There is also the possibility to automatically fix (most of) the linters issues.

@alexbovet alexbovet merged commit 9ad926c into main Aug 14, 2024
3 of 4 checks passed
@j-i-l j-i-l added this to the JOSS paper submission milestone Aug 14, 2024
@j-i-l j-i-l mentioned this pull request Aug 15, 2024
@j-i-l j-i-l deleted the 13-cicd-setup-for-automated-testing branch August 15, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci/cd setup for automated testing
2 participants