-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-335: migrate from Java EE to Jakarta EE #334
Open
prutheus
wants to merge
1
commit into
alexa:2.0.x
Choose a base branch
from
prutheus:migrate-java-ee-to-jakarta-ee
base: 2.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prutheus
changed the title
migrate from Java EE to Jakarta EE
GH-335: migrate from Java EE to Jakarta EE
Aug 15, 2023
prutheus
force-pushed
the
migrate-java-ee-to-jakarta-ee
branch
2 times, most recently
from
September 11, 2023 06:23
5c81c65
to
9034697
Compare
prutheus
force-pushed
the
migrate-java-ee-to-jakarta-ee
branch
from
September 11, 2023 06:43
9034697
to
f9b1a37
Compare
prutheus
commented
Sep 11, 2023
Comment on lines
+156
to
+169
@Override | ||
public boolean isFinished() { | ||
return false; | ||
} | ||
|
||
@Override | ||
public boolean isReady() { | ||
return false; | ||
} | ||
|
||
@Override | ||
public void setReadListener(ReadListener readListener) { | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further refinement required
Comment on lines
+187
to
+195
@Override | ||
public boolean isReady() { | ||
return false; | ||
} | ||
|
||
@Override | ||
public void setWriteListener(WriteListener writeListener) { | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further refinement required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-335
Description
Migrate Java EE to Jakarta EE.
Motivation and Context
As the
ask-sdk-servlet-support
is mostly used in combination withspring-boot
, to support the latestspring-boot
releases a migration from Java EE to Jakarta EE is required.