Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linters test #18

Open
wants to merge 33 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
9785206
rename linter actions
bsavitzky Nov 13, 2023
0e54406
removes redundant linting action
bsavitzky Nov 14, 2023
4aa57d8
adding E501 to expect fail
alex-rakowski Nov 14, 2023
16bfb1c
moving .flake8 file
alex-rakowski Nov 14, 2023
071823c
changing : to =
alex-rakowski Nov 14, 2023
988a9a3
updating flake8
alex-rakowski Nov 14, 2023
8908d57
updating flake8
alex-rakowski Nov 14, 2023
cc4614d
updating flake8
alex-rakowski Nov 14, 2023
fb89299
removing E501 expecting pass
alex-rakowski Nov 14, 2023
0da46fa
adding as string with E501 expecting fail
alex-rakowski Nov 14, 2023
ff21449
adding as non string without E501 expecting pass
alex-rakowski Nov 14, 2023
fa1cd11
adding some configs expecting fails
alex-rakowski Nov 14, 2023
6e79493
removing 501 expecting pass
alex-rakowski Nov 14, 2023
43cfadf
adding dummy test and E501 expecting pass
alex-rakowski Nov 14, 2023
4acebcc
altering dummy and seeing if top level flake works
alex-rakowski Nov 14, 2023
5bdf2f2
clearning up last commit
alex-rakowski Nov 14, 2023
75ee62f
moving .flake8 back to .github
alex-rakowski Nov 14, 2023
0093113
changing to *test/*
alex-rakowski Nov 14, 2023
44c3dd5
changing to **test/*
alex-rakowski Nov 14, 2023
856b645
changing to test
alex-rakowski Nov 14, 2023
9443afa
updating to v5
alex-rakowski Nov 14, 2023
be9d0c6
changing to test_
alex-rakowski Nov 14, 2023
16f907d
adding new line to test_dummy
alex-rakowski Nov 14, 2023
0d15273
adding new line to test_dummy
alex-rakowski Nov 14, 2023
1a35e2b
filtering to search py4DSTEM only
alex-rakowski Nov 14, 2023
4eea266
trying to add new path to flake file
alex-rakowski Nov 14, 2023
f552b52
adding ignore __init__.py
alex-rakowski Nov 14, 2023
1c1fff1
updating .flake8 rules
alex-rakowski Nov 14, 2023
8de85ba
updating excluding + comments
alex-rakowski Nov 14, 2023
360779a
updating and adding comments
alex-rakowski Nov 14, 2023
6589111
removing dummy test file
alex-rakowski Nov 14, 2023
9790913
removing file
alex-rakowski Nov 14, 2023
b217814
conflict errors
alex-rakowski Nov 15, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/linters/.flake8

This file was deleted.

40 changes: 0 additions & 40 deletions .github/workflows/build-flake.yml

This file was deleted.

17 changes: 11 additions & 6 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Check for errors with flake8
name: Lint with super-linter@v5-slim

on:
push:
Expand All @@ -17,9 +17,14 @@ jobs:
fetch-depth: 0

- name: Lint Code Base
uses: github/super-linter@v4
uses: super-linter/super-linter/slim@v5 # updated to latest slim as quicker to download
env:
VALIDATE_ALL_CODEBASE: false
VALIDATE_PYTHON_FLAKE8: true
DEFAULT_BRANCH: "dev"
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
VALIDATE_ALL_CODEBASE: false # only check changes
VALIDATE_PYTHON_FLAKE8: true # lint with flake8
DEFAULT_BRANCH: "dev" # set default branch to dev
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # for github things
# FILTER_REGEX_EXCLUDE: .*test/.* # exclude test dirs
FILTER_REGEX_EXCLUDE: .*__init__.py/.* # exclude test dirs
FILTER_REGEX_INCLUDE: .*py4DSTEM/.* # only look for py4DSTEM
LINTER_RULES_PATH: / # set toplevel dir as the path to look for rules
PYTHON_FLAKE8_CONFIG_FILE: .flake8 # set specific config file
Loading