Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firewall 7.0.0 compat #40

Merged
merged 8 commits into from
Sep 24, 2023
Merged

firewall 7.0.0 compat #40

merged 8 commits into from
Sep 24, 2023

Conversation

robertc99
Copy link
Collaborator

Compatability fixes for firewall 7.0.0

@robertc99
Copy link
Collaborator Author

Not sure why the checks are failing. the ruby 2.7 check almost passes. The rest are probably irrelevant at this stage.
Probably needs to add ruby 3.2 and puppet 8.

@robertc99
Copy link
Collaborator Author

Ok, Ive managed to get the self checks to pass.
Theres an ugly issue where there are now two different parameters proto and protocol, but places in the code refer to proto as protocol.

@alex-harvey-z3q alex-harvey-z3q merged commit 244ee18 into alex-harvey-z3q:master Sep 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertc99 @alex-harvey-z3q