Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecesary dependencies in lc_classifier #517

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ignacioreyes
Copy link
Member

Summary of the changes

bye bye imblearn, scikit learn, tensorflow and requests from lc_classifier dependencies
Some other very minor changes.

Observations

<-- Add some notes to keep in mind !-->

If the change is BREAKING, please give more details about the breaking changes

<-- What change breaks what and how !-->

Components that need updates and steps to follow

<-- Link repos or other PRs !-->

About this PR:

  • You added the necessary documentation for the team to understand your work.
  • You linked this PR to the corresponding issue or user story.
  • Your changes fulfill the Definition of Done of the issue or user story.
  • Your changes were tested with manual testing before being submitted.
  • Your changes were tested with automatic unit tests.
  • Your changes were tested with automatic integration tests.

Screensshots

<-- Add some screenshots if necessary !-->

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.12%. Comparing base (576445c) to head (87bbb70).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   75.12%   75.12%           
=======================================
  Files          29       29           
  Lines        2726     2726           
=======================================
  Hits         2048     2048           
  Misses        678      678           
Flag Coverage Δ
lc_classifier 75.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant