Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LC Classification Step: Use oid to group objects #367

Merged
merged 8 commits into from
Jan 3, 2024

Conversation

dirodriguezm
Copy link
Contributor

Summary of the changes

  • Uses oid instead of aid to group objects
  • Update the elasticc models as well
  • Refactor logging logic so that it only runs on errors

If the change is BREAKING, please give more details about the breaking changes

  • The grouping is now oid and not aid

Components that need updates and steps to follow

The alerce classifiers repo should be updated by merging this PR, but after merging this one first.

About this PR:

  • You added the necessary documentation for the team to understand your work.
  • You linked this PR to the corresponding issue or user story.
  • Your changes fulfill the Definition of Done of the issue or user story.
  • Your changes were tested with manual testing before being submitted.
  • Your changes were tested with automatic unit tests.
  • Your changes were tested with automatic integration tests.

@dirodriguezm dirodriguezm merged commit d1e20c1 into main Jan 3, 2024
11 checks passed
@dirodriguezm dirodriguezm deleted the refactor/lc-classifier-group-by-oid branch January 3, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants