Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/schemaless consumer use path #265

Merged
merged 87 commits into from
Nov 22, 2023

Conversation

AlxEnashi
Copy link
Contributor

Summary of the changes

The apf consumer and producer now load the schema from a file path.

Observations

Not ready

If the change is BREAKING, please give more details about the breaking changes

Braks the whole pipeline. Need more changes to be merged

Components that need updates and steps to follow

<-- Link repos or other PRs !-->

About this PR:

  • You added the necessary documentation for the team to understand your work.
  • You linked this PR to the corresponding issue or user story.
  • Your changes fulfill the Definition of Done of the issue or user story.
  • Your changes were tested with manual testing before being submitted.
  • Your changes were tested with automatic unit tests.
  • Your changes were tested with automatic integration tests.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (2dcb6ac) 82.66% compared to head (cf07873) 71.94%.
Report is 25 commits behind head on main.

❗ Current head cf07873 differs from pull request most recent head 47cd524. Consider uploading reports for the commit 47cd524 to get more accurate results

Files Patch % Lines
correction_step/correction/_step/step.py 11.11% 8 Missing ⚠️
correction_step/correction/_step/settings.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #265       +/-   ##
===========================================
- Coverage   82.66%   71.94%   -10.73%     
===========================================
  Files          48       38       -10     
  Lines        1552     1365      -187     
===========================================
- Hits         1283      982      -301     
- Misses        269      383      +114     
Flag Coverage Δ
unittest 71.94% <36.84%> (-10.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AlxEnashi and others added 27 commits November 6, 2023 04:04
…ercebroker/pipeline into refactor/steps_integration_tests
@dirodriguezm dirodriguezm linked an issue Nov 16, 2023 that may be closed by this pull request
@edipizarro edipizarro merged commit 894b956 into main Nov 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment