Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using the fp's pid as the pkey with oid #237

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

pgallardor
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3b059e5) 88.59% compared to head (2b145fc) 88.44%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   88.59%   88.44%   -0.16%     
==========================================
  Files          32       32              
  Lines        1684     1688       +4     
==========================================
+ Hits         1492     1493       +1     
- Misses        192      195       +3     
Flag Coverage Δ
unittest 88.44% <50.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
libs/db-plugins/db_plugins/db/sql/models.py 99.24% <100.00%> (ø)
lightcurve-step/lightcurve_step/step.py 72.72% <ø> (ø)
scribe/mongo_scribe/sql/command/commands.py 93.82% <100.00%> (ø)
sorting_hat_step/sorting_hat_step/utils/wizard.py 95.12% <100.00%> (ø)
scribe/mongo_scribe/mongo/command/commands.py 86.04% <50.00%> (-0.86%) ⬇️
...orting_hat_step/sorting_hat_step/utils/database.py 67.74% <0.00%> (-4.68%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirodriguezm dirodriguezm merged commit fdf1dbd into main Oct 23, 2023
37 of 39 checks passed
@dirodriguezm dirodriguezm deleted the refactor/fp-pid-pkey branch October 23, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants