Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Parse filters form CSV file when creating a watchlist #52

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Fix: Parse filters form CSV file when creating a watchlist #52

merged 2 commits into from
Apr 29, 2024

Conversation

HectorxH
Copy link
Contributor

No description provided.

@HectorxH HectorxH requested a review from Demurest April 26, 2024 20:26
@HectorxH HectorxH self-assigned this Apr 26, 2024
@Demurest
Copy link
Contributor

El type de filter en csvTarget, debería ser tipo IWatchlistFilter.

@HectorxH
Copy link
Contributor Author

HectorxH commented Apr 26, 2024 •
edited
Loading

@Demurest csvTarget es el tipo que retorna el csv parser. En este caso el parser lo toma como un string, por lo que creo que es mejor re interpretarlo como IWatchlistFilter despues de hacer JSON.parse.

@HectorxH HectorxH merged commit f83fb18 into develop Apr 29, 2024
3 checks passed
@HectorxH HectorxH deleted the fix/csv-loading-with-filters branch April 29, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Demurest Demurest Demurest approved these changes

Assignees

@HectorxH HectorxH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HectorxH @Demurest