Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KMS Support for Guardian Node #36

Merged
merged 14 commits into from
Nov 13, 2022
Merged

Add KMS Support for Guardian Node #36

merged 14 commits into from
Nov 13, 2022

Conversation

h0ngcha0
Copy link
Member

No description provided.

Lbqds
Lbqds approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@Lbqds Lbqds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, only two minor comments.

node/pkg/ecdsasigner/cloudkms.go Outdated Show resolved Hide resolved
node/pkg/p2p/p2p.go Outdated Show resolved Hide resolved
polarker
polarker reviewed Oct 28, 2022
View reviewed changes
Copy link
Member

@polarker polarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done my first round, great work 👍 I will review it one more round since this is a critical feature.

node/pkg/ecdsasigner/cloudkms.go Outdated Show resolved Hide resolved
node/pkg/ecdsasigner/ecdsasigner_test.go Outdated Show resolved Hide resolved
node/pkg/ecdsasigner/cloudkms.go Outdated Show resolved Hide resolved
node/pkg/ecdsasigner/cloudkms.go Outdated Show resolved Hide resolved
node/pkg/ecdsasigner/ecdsasigner_test.go Show resolved Hide resolved
clients/js/vaa.ts Outdated Show resolved Hide resolved
node/alephium-wormhole-9be054708cef-test-only.json Outdated Show resolved Hide resolved
polarker
polarker reviewed Oct 28, 2022
View reviewed changes
clients/js/vaa.ts Outdated Show resolved Hide resolved
polarker
polarker reviewed Nov 8, 2022
View reviewed changes
node/pkg/ecdsasigner/ecdsaprivatekey_test.go Outdated Show resolved Hide resolved
node/pkg/ecdsasigner/cloudkms.go Outdated Show resolved Hide resolved
clients/js/vaa.ts Outdated Show resolved Hide resolved
clients/js/vaa.ts Outdated Show resolved Hide resolved
clients/js/vaa.ts Outdated Show resolved Hide resolved
clients/js/vaa.ts Outdated Show resolved Hide resolved
node/cmd/guardiand/node.go Outdated Show resolved Hide resolved
clients/js/vaa.ts Outdated Show resolved Hide resolved
polarker
polarker approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@polarker polarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two nitpicking comments.

clients/js/package.json Outdated Show resolved Hide resolved
node/cmd/guardiand/node.go Show resolved Hide resolved
@h0ngcha0 h0ngcha0 merged commit a3ca723 into add-alephium-to-wormhole Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lbqds Lbqds Lbqds approved these changes

@polarker polarker polarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h0ngcha0 @polarker @Lbqds