Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test against Go 1.20 and 1.21 #404

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

abhinav
Copy link
Contributor

@abhinav abhinav commented Dec 10, 2023

Per the Go Release Policy, upstream supports
only the two most recent major releases of Go.
For example, with Go 1.21 available, only 1.21 and 1.20 are supported.
Many projects adopt a similar support policy
to strike a balance between new features and backwards support.

If Kong has the same policy,
it makes sense to test against both versions of Go.

This change adds a test matrix to CI,
testing against both Go 1.20 and 1.21,
on both Windows and Linux.

For Linux, it installs the desired version on demand,
because I couldn't find a way to have multiple versions
coexist with Hermit.

Per the [Go Release Policy][1], upstream supports
only the two most recent major releases of Go.
For example, with Go 1.21 available, only 1.21 and 1.20 are supported.
Many projects adopt a similar support policy
to strike a balance between new features and backwards support.

  [1]: https://go.dev/doc/devel/release#policy

If the project has the same policy,
it makes sense to test against both versions of Go.

This change adds a test matrix to CI,
testing against both Go 1.20 and 1.21,
on both Windows and Linux.
@abhinav abhinav marked this pull request as ready for review December 10, 2023 23:56
@alecthomas alecthomas merged commit de00f3b into alecthomas:master Dec 11, 2023
5 checks passed
@alecthomas
Copy link
Owner

For Linux, it installs the desired version on demand, because I couldn't find a way to have multiple versions coexist with Hermit.

That's to be expected, as that is one of the primary design goals of Hermit.

@abhinav abhinav deleted the multi-go branch December 11, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants