This repository has been archived by the owner on Jan 11, 2019. It is now read-only.
django-cms 3.5 support #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(*) still weirdness that the plugin needs to be rendered in new style rendering (with separate structure rendering). I'm unsure why this is the case. - Not longer supporting django CMS<3.5 - Dropped Django<1.8 support.
stefanfoulis
force-pushed
the
feature/cms-3.5-support
branch
from
79e099d to
e5bfa9a
Compare
czpython
approved these changes
Aug 24, 2017
| @@ -2,66 +2,41 @@ | |||
|
|
|||
| from __future__ import unicode_literals | |||
|
|
|||
| from cms.toolbar.utils import get_toolbar_from_request | |||
There was a problem hiding this comment.
please move this over the cms_tags import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these changes will make aldryn-segment only work with the not yet released django CMS 3.5, we're holding off the merge for now.
(*) still weirdness that the plugin needs to be rendered in new style
rendering (with separate structure rendering). I'm unsure why this is
the case.