This repository has been archived by the owner on Dec 21, 2022. It is now read-only.
Only modify urls if running as DEBUG and not during unit tests. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only modify urls DEBUG is True: Should be obvious why this is a good idea. Disable during unit testing: Django debug toolbar and view based tests don't always work well together so disable under test.
Aiky30
reviewed
Jan 24, 2020
| import debug_toolbar | ||
|
|
||
| urlpatterns = [url(r'^__debug__/', include(debug_toolbar.urls))] | ||
| if settings.DEBUG and 'test' not in sys.argv: | ||
| urlpatterns = [url(r'^__debug__/', include(debug_toolbar.urls))] |
There was a problem hiding this comment.
url is Django < 2, Will need a check for path for 2 =>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only modify urls DEBUG is True:
Should be obvious why this is a good idea.
Disable during unit testing:
Django debug toolbar and view based tests don't always work well together don't add debug toolbar urls when running unit tests.