Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pool): don't log an error during validation failure in gas check #914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dancoombs
Copy link
Collaborator

No description provided.

0xfourzerofour
0xfourzerofour previously approved these changes Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.13%. Comparing base (663a373) to head (cd1a989).

Files with missing lines Patch % Lines
crates/pool/src/mempool/uo_pool.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/contracts/src/v0_7.rs 97.33% <ø> (ø)
crates/sim/src/estimation/v0_6.rs 94.82% <ø> (ø)
crates/sim/src/estimation/v0_7.rs 81.09% <ø> (ø)
crates/pool/src/mempool/uo_pool.rs 92.09% <0.00%> (-0.06%) ⬇️
Flag Coverage Δ
unit-tests 59.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 65.06% <ø> (ø)
dev ∅ <ø> (∅)
pool 66.64% <0.00%> (-0.01%) ⬇️
provider 20.84% <ø> (ø)
rpc 25.87% <ø> (ø)
sim 76.76% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.81% <ø> (ø)
utils 31.73% <ø> (ø)
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants