Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lo-fi otp component and storybook testing #1166

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

RobChangCA
Copy link
Collaborator

@RobChangCA RobChangCA commented Nov 20, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing the OTPInput component by adding new features, improving error handling, and updating dependencies in the project.

Detailed summary

  • Added an otp.invalid error message in strings.ts.
  • Updated @storybook/addon-interactions and @storybook/test to version 8.4.4 in package.json.
  • Implemented new stories for OTPInput in otp-input.stories.tsx, including tests for typing, pasting, and keyboard navigation.
  • Enhanced the OTPInput component in otp-input.tsx with better state management and error handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

graphite-app bot commented Nov 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:46pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:46pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant