PHRAS-2069 rescan file metadata command #4420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jygaulier
reviewed
Nov 27, 2023
| } | ||
|
|
||
| $stmt->execute(); | ||
| $rows = $stmt->fetchAll(\PDO::FETCH_ASSOC); |
There was a problem hiding this comment.
beware of big databoxes : better read row by row, and get only the needed column record_id
jygaulier
reviewed
Nov 27, 2023
| ->addOption('source', null, InputOption::VALUE_REQUIRED, 'tag to search exemple IPTC:KEYWORD') | ||
| ->addOption('destination', null, InputOption::VALUE_REQUIRED, "ID of the field de fill") | ||
| ->addOption('overwrite', null, InputOption::VALUE_NONE, "act even if the destination field has a value in databox") | ||
| ->addOption('multi', null, InputOption::VALUE_REQUIRED, "replace or merge for multi value field") |
There was a problem hiding this comment.
should be --method :
- replace : overwrite the whole value with new one(s)
- merge : for multi only = merge actual and new values
- prepend : for mono only = add before (to do later because need to enhance setMetaByActions() )
- append : for mono only = add after (to do later)
jygaulier
reviewed
Nov 27, 2023
|
|
||
| $sql_where = join(" AND ", $clauses); | ||
|
|
||
| $sql = "SELECT * FROM record WHERE " . $sql_where; |
There was a problem hiding this comment.
don't use * ;
overwrite = null optim: ... left join metadata... where ... and isnull(metadata) so the select will not fetch records with value(s).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Adds