-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global improvements #25
Open
gnutix
wants to merge
12
commits into
alchemy-fr:master
Choose a base branch
from
gnutix:improve-tests-setup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnutix
force-pushed
the
improve-tests-setup
branch
from
March 31, 2020 07:42
5b10ac9
to
cbe61d8
Compare
gnutix
changed the title
Add PHP 7.3 + 7.4 to Travis, remove deprecated PHPUnit option.
Improve the tests setup
Mar 31, 2020
This was referenced Mar 31, 2020
gnutix
force-pushed
the
improve-tests-setup
branch
from
March 31, 2020 08:06
b2c5095
to
4e63025
Compare
gnutix
force-pushed
the
improve-tests-setup
branch
from
March 31, 2020 08:11
4e63025
to
0901e94
Compare
…o improve-tests-setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes #23 (as it touched
composer.json
anyway), and :TestCase
class with namespace did not existed back in this version)syntaxCheck
)Data::buildFromUrl()
(to prevent network errors in tests)sami/sami
to ^4.1 (needed to usesymfony/process
that runs the local web server). I had to remove thetheme => enhanced
line insami_configuration.php
to run./buildAPI.sh
. However, I did not committed the changes done in the docs in this PR, as it's outside the scope of my knowledge whether the changes would be good or not.You can see the build (including #23 and #24) passing here : https://github.com/gnutix/PHP-dataURI/pull/2/checks