-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert flamel to a simple CLI #10
Conversation
Add missing unit conversion in pickle output
Main changes: - make the `energy_unit` attribute propagate through the `uncorrelate` plugins. - use alchemlybs new conversion feature to facilitate easy unit conversion. - Removed `text` output plugin. This was just a file version of the `alchemical-analysis` output. Moved into the `alchemical-analysis` plugin
I am ok with your rewrite. But I will quickly make a historical 0.1.0 release with the original main branch, then merge PR #1 and make a historical 0.2.0, just so that the code remains in the history. |
- close alchemistry#4 - add retroactive history
…to xiki-tempula-feat_ABFE - update CHANGES - update AUTHORS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rewrite is in line with discussion #12 .
I added CHANGES and AUTHORS and added it to the branch.
@orbeckst Many thanks for merging this PR. I wonder what is https://github.com/alchemistry/flamel/blob/master/output/pickle.py? I think the file might be introduced by #1 and is no longer needed now. |
oops... I overlooked it in the merge, I'll do a clean-up |
While checking things: Did you use versioneer in the template? I don't see any versioneer files or how is versioning handled? For local test I get
|
I expect the versioning to be handled by |
Locally it works for me
Obviously, one has to create a tag release in order to change this version. |
Do I need to install something?
… Am 11/7/22 um 02:43 schrieb Zhiyi Wu ***@***.***>:
Locally it works for me
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
@orbeckst So I think you will need to do |
Thanks, learning how to live without setup.py and other old-school tools ;-) |
Given that alchemlyb has reached 1.0. I have also formated the flamel to be a simple CLI interface.
This PR allows flamel to use the alchemlyb.workflow.ABFE as backend and allow this kind of usage.
flamel -a GROMACS -d {in_path} -f 10 -g -i 50 -j result.csv -m TI,BAR,MBAR -n dE -o {out} -p dhdl -q xvg.bz2 -r 3 -s 50 -t 298 -v -w
I have refactored the project to make it adopt the molssi cookie-cutter format. I have also added the tests.