-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the error handling in the backward and forward convergence #358
Conversation
…mlyb into feat_fastMBAR
Co-authored-by: Oliver Beckstein <[email protected]>
Co-authored-by: Oliver Beckstein <[email protected]>
Co-authored-by: Oliver Beckstein <[email protected]>
Co-authored-by: Oliver Beckstein <[email protected]>
Co-authored-by: Oliver Beckstein <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 28 28
Lines 1890 1895 +5
Branches 409 407 -2
=======================================
+ Hits 1868 1873 +5
Misses 2 2
Partials 20 20 ☔ View full report in Codecov by Sentry. |
@xiki-tempula you'll have to manually resolve these conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you remove the speed-up for the convergence estimate (ie using the bar estimate)? If so update CHANGES (and docs where necessary).
Co-authored-by: Oliver Beckstein <[email protected]>
Co-authored-by: Oliver Beckstein <[email protected]>
In the backward and forward convergence, for the initial set of points, which uses for example the first 10% of the date, it could be the cases where due to the fact that there are not many data points, so the overlap is pretty bad, which gives terrible statistical error.
This PR is build on #357.
The PR allow the user to specify a error tolerance. If the statistical error is too bad, use the bootstrap error instead choderalab/pymbar#519.