Linter on ci #31
Merged
Linter on ci #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaintextpaco
force-pushed
the
linter-ci
branch
10 times, most recently
from
3910e44 to
bee0676
Compare
plaintextpaco
force-pushed
the
linter-ci
branch
from
bee0676 to
308d288
Compare
I want to make sure we don't commit & push tests with .only on them
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't rebase any PR on top of this one, it's infinitely easier to rebase this on top of whatever else
Merge after #28
In the near future we should implement the solhint suggestions that are 'warnings' and make them errors, created issue #30 to track that