Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy current model and datasource entries to scivision #477

Merged
merged 27 commits into from
Jan 18, 2023

Conversation

edwardchalstrey1
Copy link
Contributor

@edwardchalstrey1 edwardchalstrey1 commented Jan 6, 2023

Changes

Closes #470

Notebooks to update after merge, due to name changes

  • Update notebooks that use "data-003" (Koala) to new name (test data)
  • Update notebooks that use "data-004" (plankton) to new name
  • Update treecrown notebook to datasource new name
  • Update coastal edges notebook to new datasource name
  • Update notebooks that use "scivision_sentinel2_stac" to new name

@edwardchalstrey1
Copy link
Contributor Author

edwardchalstrey1 commented Jan 9, 2023

@acocac

  1. Are you happy with the name changes for coastal edges and treecrowns datasources?
  2. Could we provide a description of these datasources other than "they are used for this model" - which will make them seem more useful to scivision users for other purposes?
  3. Can you provide a suitable image for both of these we can use as a thumbnail in the UI?

@edwardchalstrey1
Copy link
Contributor Author

@scotthosking @acocac @mooniean @evangeline-corcoran

Can you double-check I was correct to remove the duplicate plankton datasource?

@edwardchalstrey1
Copy link
Contributor Author

@mooniean Can you provide a suitable thumbnail for Parakeet?

@edwardchalstrey1
Copy link
Contributor Author

edwardchalstrey1 commented Jan 9, 2023

@quantumjot

  1. can you provide a suitable thumbnail for "cell-cycle-scivision"? DONE: Add cell dataset thumbnail #481
  2. Are you happy with the removal of "scivision-test-plugin"? I have done this because I also added "image-classifiers", which is based off that one but further developed, allowing the user to use any of the models in that Python package (image-classifiers)

@edwardchalstrey1 edwardchalstrey1 changed the title Model ds updates Tidy current model and datasource entries to scivision Jan 9, 2023
@ots22
Copy link
Member

ots22 commented Jan 9, 2023

@scotthosking @acocac @mooniean @evangeline-corcoran

Can you double-check I was correct to remove the duplicate plankton datasource?

I'm assuming these are data-002 and the renamed data-004. It looks like the url for the former no longer resolves sadly (planktonclub.ie). I'd be in favour of removing given this and that it was only a single example image.

I just opened #479 on performing a regular check of URLs in the catalog (I think we've discussed it before, so sorry if there's another issue I missed)

@quantumjot
Copy link
Collaborator

Are you happy with the removal of "scivision-test-plugin"?

Yes, I don't see why not. Unless it's useful to developers who are adding their own models?

@acocac
Copy link
Member

acocac commented Jan 17, 2023

@edwardchalstrey1, fyi

  1. Are you happy with the name changes for coastal edges and treecrowns datasources?

Yes. Names are ok for me.

  1. Could we provide a description of these datasources other than "they are used for this model" - which will make them seem more useful to scivision users for other purposes?

Done. I directly pushed updated descriptions into this PR. Hope it's ok for you.

  1. Can you provide a suitable image for both of these we can use as a thumbnail in the UI?

Done.

@edwardchalstrey1
Copy link
Contributor Author

Are you happy with the removal of "scivision-test-plugin"?

Yes, I don't see why not. Unless it's useful to developers who are adding their own models?

@quantumjot yes fair enough, I could rename image-classifiers to scivision-example-plugin or similar and have it a bit better documented for this purpose

@edwardchalstrey1 edwardchalstrey1 marked this pull request as ready for review January 18, 2023 16:24
@edwardchalstrey1 edwardchalstrey1 merged commit 295b396 into main Jan 18, 2023
@edwardchalstrey1 edwardchalstrey1 deleted the model-ds-updates branch January 18, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure all current models and datasets have appropriate thumbnails, names and descriptions
4 participants