Skip to content

Commit

Permalink
fix(@angular/build): move lmdb to optionalDependencies
Browse files Browse the repository at this point in the history
A warning mechanism has been implemented to notify users when lmdb is unavailable. On Windows ARM64 systems, however, installing this package with pnpm appears to cause installation failures.

See: angular#27882 (comment)

Closes angular#27882
  • Loading branch information
alan-agius4 committed Oct 9, 2024
1 parent 7c50ba9 commit 148de3b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/angular/build/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
"https-proxy-agent": "7.0.5",
"istanbul-lib-instrument": "6.0.3",
"listr2": "8.2.5",
"lmdb": "3.1.3",
"magic-string": "0.30.11",
"mrmime": "2.0.0",
"parse5-html-rewriting-stream": "7.0.0",
Expand All @@ -45,6 +44,9 @@
"vite": "5.4.8",
"watchpack": "2.4.2"
},
"optionalDependencies": {
"lmdb": "3.1.3"
},
"peerDependencies": {
"@angular/compiler": "^19.0.0-next.0",
"@angular/compiler-cli": "^19.0.0-next.0",
Expand Down
3 changes: 3 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,9 @@ __metadata:
postcss: ^8.4.0
tailwindcss: ^2.0.0 || ^3.0.0
typescript: ">=5.5 <5.7"
dependenciesMeta:
lmdb:
optional: true
peerDependenciesMeta:
"@angular/localize":
optional: true
Expand Down

0 comments on commit 148de3b

Please sign in to comment.