Add data(key, value) method to widget factories. (eclipse-platform#1403)

* Add data(key, value) method to widget factories. Issues: eclipse-platform#1399 * Update bundles/org.eclipse.jface/src/org/eclipse/jface/widgets/AbstractWidgetFactory.java Co-authored-by: Matthias Becker <[email protected]> --------- Co-authored-by: Matthias Becker <[email protected]>
akurtakov · Dec 13, 2023 · a7df241 · a7df241
1 parent ec32609
commit a7df241
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/widgets/AbstractWidgetFactory.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/widgets/AbstractWidgetFactory.java
@@ -102,4 +102,21 @@ public F data(Object data) {
 		addProperty(b -> b.setData(data));
 		return cast(this);
 	}
+
+	/**
+	 * Sets the application defined property of the receiver with the specified name
+	 * to the given value.
+	 *
+	 * @param key   the name of the property
+	 * @param value the new value for the property
+	 * @return this
+	 *
+	 * @see Widget#setData(String, Object)
+	 *
+	 * @since 3.33
+	 */
+	public F data(String key, Object value) {
+		addProperty(b -> b.setData(key, value));
+		return cast(this);
+	}
 }
diff --git a/tests/org.eclipse.jface.tests/src/org/eclipse/jface/tests/widgets/TestUnitWidgetFactory.java b/tests/org.eclipse.jface.tests/src/org/eclipse/jface/tests/widgets/TestUnitWidgetFactory.java
@@ -54,4 +54,14 @@ public void setsData() {
 
 		assertEquals(data, testLabel.getData());
 	}
+
+	@Test
+	public void setsDataWithKey() {
+		String data1 = "data1";
+		String data2 = "data2";
+		Label testLabel = LabelFactory.newLabel(SWT.NONE).data("id1", data1).data("id2", data2).create(shell);
+
+		assertEquals(data1, testLabel.getData("id1"));
+		assertEquals(data2, testLabel.getData("id2"));
+	}
 }