Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update kargo quickstart guide #2521

Merged
merged 10 commits into from
Oct 24, 2024
Merged

Conversation

fykaa
Copy link
Contributor

@fykaa fykaa commented Sep 11, 2024

@fykaa fykaa self-assigned this Sep 11, 2024
@fykaa fykaa requested review from a team as code owners September 11, 2024 15:20
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit d1519bd
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66f67ff0ae0ed200088a1d00
😎 Deploy Preview https://deploy-preview-2521.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fykaa fykaa changed the title improvement: update Quickstart with udpated UI Snapshots docs: improve Quickstart with udpated UI Snapshots Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.82%. Comparing base (5af701f) to head (fd27eb6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2521   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files         270      270           
  Lines       23941    23941           
=======================================
  Hits        11690    11690           
  Misses      11620    11620           
  Partials      631      631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour
Copy link
Member

General comment -- this is a modest improvement. 👍

Let's also plan, however, on providing more UI-centric instructions. i.e. Instead of just "this is what it will look like when you click this link," we also need "click this, then click that," as an alternative to the CLI-based instructions.

@fykaa fykaa force-pushed the improve-docs-quickstart branch from 205f293 to ddf3238 Compare September 12, 2024 20:15
@fykaa
Copy link
Contributor Author

fykaa commented Sep 12, 2024

Addressed all the reviews @kencochrane

Regarding the need for more clarity on clicks, I believe that adding multiple screenshots inline may not be the most user-friendly approach.
Should I consider using Supademo to illustrate each component instead?

@fykaa fykaa requested a review from krancour September 12, 2024 22:08
@krancour
Copy link
Member

Regarding the need for more clarity on clicks, I believe that adding multiple screenshots inline may not be the most user-friendly approach.

I agree. So let's not constrain the effort of providing the quickstart with a UI perspective to just adding screenshots. There are other effective ways to document navigation of a UI.

This page has an example of how (stylystically speaking) we have documented certain steps on GitHub:

https://kargo.akuity.io/how-to-guides/managing-credentials/#github-app-authentication

There is also information about how to do this in the "Referencing UI elements" section of the style guide:

https://github.com/akuity/kargo/blob/main/docs/STYLE_GUIDE.md#referencing-ui-elements

Should I consider using Supademo to illustrate each component instead?

I want to see how far we can get without falling back on this. I'm entirely unopposed to it as a supplement to proper docs, but I don't want to skimp on the text-based docs specifically because they're ingestible by search engines and LLMs.

@fykaa
Copy link
Contributor Author

fykaa commented Sep 27, 2024

@krancour I’ve added some styles to guide users with actionable steps, similar to the approach used in other guides. Do you think there’s room for further improvement in the Quickstart guide at this stage?

As a new reader, my main concern was the lack of graphics, which I believe is now addressed here. Everything else on the page seems to work well. Do you think we need to enhance navigation further, or is it good as is?

@krancour krancour modified the milestones: v0.9.0, v0.10.0 Sep 30, 2024
docs/docs/20-quickstart.md Outdated Show resolved Hide resolved
docs/docs/20-quickstart.md Outdated Show resolved Hide resolved
@krancour
Copy link
Member

Additional notes that I couldn't add inline because they weren't near any changes...

If we're making this more UI-centric, I think we need some brief explanatory text around line 289 (just before logging in using the Kargo CLI) about why we're using the CLI: There's a lot of configuration and it's easiest to create it declaratively.

I also think that section might be a good place to add some tabs showing how that step can be accomplished with either the Kargo CLI or kubectl. (kubectl is actually easier because there's no logging in required.) If you do this, you could also edit the section on installing the CLI so that it's designated as an optional step.

Signed-off-by: Faeka Ansari <[email protected]>

address review: rephrase

Signed-off-by: Faeka Ansari <[email protected]>
@fykaa fykaa force-pushed the improve-docs-quickstart branch from ac3d8f3 to a643464 Compare October 24, 2024 14:39
@krancour
Copy link
Member

I also think that section might be a good place to add some tabs showing how that step can be accomplished with either the Kargo CLI or kubectl. (kubectl is actually easier because there's no logging in required.) If you do this, you could also edit the section on installing the CLI so that it's designated as an optional step.

I put more thought into this...

I think we should indeed use tabs to give the user the choice of kubectl or the kargo CLI for declaratively setting up the Project and:

  • Use a line of introductory text above indicating there are two ways to proceed with the steps in this section.

  • Make kubectl the default tab as there's less effort involved -- no download required; no login required.

  • Move the whole section on downloading/installing the CLI into the kargo tab.

This will make the quickstart considerably shorter in appearance and in terms of steps a user must complete unless they opt-in to using kargo instead of kubectl.

I don't (yet?) want to remove kargo CLI bits entirely because I think just having the option there calls new users' attention to the fact it exists -- something that may be easily overlooked otherwise.

@fykaa fykaa force-pushed the improve-docs-quickstart branch from 78c3c5a to 1fa5af3 Compare October 24, 2024 15:56
docs/docs/20-quickstart.md Outdated Show resolved Hide resolved
@fykaa fykaa requested a review from krancour October 24, 2024 16:04
fix nits

Signed-off-by: Faeka Ansari <[email protected]>
@fykaa fykaa force-pushed the improve-docs-quickstart branch from f932650 to fe7a25a Compare October 24, 2024 17:07
@fykaa fykaa changed the title docs: improve Quickstart with udpated UI Snapshots docs: update kargo quickstart guide Oct 24, 2024
docs/docs/20-quickstart.md Outdated Show resolved Hide resolved
@krancour krancour enabled auto-merge October 24, 2024 19:01
@krancour krancour added this pull request to the merge queue Oct 24, 2024
Merged via the queue into akuity:main with commit 3b4e223 Oct 24, 2024
17 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
Signed-off-by: Faeka Ansari <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Co-authored-by: Kent Rancourt <[email protected]>
(cherry picked from commit 3b4e223)
@akuitybot
Copy link

Successfully created backport PR for release-1.0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants