-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update kargo quickstart guide #2521
Conversation
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2521 +/- ##
=======================================
Coverage 48.82% 48.82%
=======================================
Files 270 270
Lines 23941 23941
=======================================
Hits 11690 11690
Misses 11620 11620
Partials 631 631 ☔ View full report in Codecov by Sentry. |
General comment -- this is a modest improvement. 👍 Let's also plan, however, on providing more UI-centric instructions. i.e. Instead of just "this is what it will look like when you click this link," we also need "click this, then click that," as an alternative to the CLI-based instructions. |
205f293
to
ddf3238
Compare
Addressed all the reviews @kencochrane Regarding the need for more clarity on clicks, I believe that adding multiple screenshots inline may not be the most user-friendly approach. |
I agree. So let's not constrain the effort of providing the quickstart with a UI perspective to just adding screenshots. There are other effective ways to document navigation of a UI. This page has an example of how (stylystically speaking) we have documented certain steps on GitHub: https://kargo.akuity.io/how-to-guides/managing-credentials/#github-app-authentication There is also information about how to do this in the "Referencing UI elements" section of the style guide: https://github.com/akuity/kargo/blob/main/docs/STYLE_GUIDE.md#referencing-ui-elements
I want to see how far we can get without falling back on this. I'm entirely unopposed to it as a supplement to proper docs, but I don't want to skimp on the text-based docs specifically because they're ingestible by search engines and LLMs. |
110985b
to
4903bc3
Compare
@krancour I’ve added some styles to guide users with actionable steps, similar to the approach used in other guides. Do you think there’s room for further improvement in the Quickstart guide at this stage? As a new reader, my main concern was the lack of graphics, which I believe is now addressed here. Everything else on the page seems to work well. Do you think we need to enhance navigation further, or is it good as is? |
Additional notes that I couldn't add inline because they weren't near any changes... If we're making this more UI-centric, I think we need some brief explanatory text around line 289 (just before logging in using the Kargo CLI) about why we're using the CLI: There's a lot of configuration and it's easiest to create it declaratively. I also think that section might be a good place to add some tabs showing how that step can be accomplished with either the Kargo CLI or kubectl. (kubectl is actually easier because there's no logging in required.) If you do this, you could also edit the section on installing the CLI so that it's designated as an optional step. |
Signed-off-by: Faeka Ansari <[email protected]> address review: rephrase Signed-off-by: Faeka Ansari <[email protected]>
ac3d8f3
to
a643464
Compare
I put more thought into this... I think we should indeed use tabs to give the user the choice of
This will make the quickstart considerably shorter in appearance and in terms of steps a user must complete unless they opt-in to using I don't (yet?) want to remove |
78c3c5a
to
1fa5af3
Compare
fix nits Signed-off-by: Faeka Ansari <[email protected]>
f932650
to
fe7a25a
Compare
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Faeka Ansari <[email protected]> Signed-off-by: Kent Rancourt <[email protected]> Co-authored-by: Kent Rancourt <[email protected]> (cherry picked from commit 3b4e223)
Successfully created backport PR for |
https://docs.kargo.io/quickstart