Fix zip path traversal vulnerability

inspired by: * MobileChromeApps#92
akrcc · Mar 4, 2024 · 3b41304 · 3b41304
1 parent 977b57d
commit 3b41304
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/src/android/Zip.java b/src/android/Zip.java
@@ -121,11 +121,20 @@ private void unzipSync(CordovaArgs args, CallbackContext callbackContext) {
                 anyEntries = true;
                 String compressedName = ze.getName();
 
+                File file = new File(outputDirectory + compressedName);
+
+                String canonicalPath = file.getCanonicalPath();
+                String canonicalOutputPath = (new File(outputDirectory)).getCanonicalPath();
+                if (!canonicalPath.startsWith(canonicalOutputPath)) {
+                    String errorMessage = "Zip traversal security error";
+                    callbackContext.error(errorMessage);
+                    Log.e(LOG_TAG, errorMessage);
+                    return;
+                }
+
                 if (ze.isDirectory()) {
-                   File dir = new File(outputDirectory + compressedName);
-                   dir.mkdirs();
+                   file.mkdirs();
                 } else {
-                    File file = new File(outputDirectory + compressedName);
                     file.getParentFile().mkdirs();
                     if(file.exists() || file.createNewFile()){
                         Log.w("Zip", "extracting: " + file.getPath());