Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow building the MySQL driver with MariaDB libraries. #506

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Allow building the MySQL driver with MariaDB libraries. #506

merged 3 commits into from
Jul 28, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jul 14, 2023

Closes #505

@dveeden dveeden force-pushed the mysql__compression_alg__mariadb branch from 5efe1da to fae19ba Compare July 14, 2023 13:07
@dveeden
Copy link
Contributor Author

dveeden commented Jul 14, 2023

I had an ifdef around

  SB_OPT("mysql-compression-algorithms", "compression algorithms to use",
         "zlib", STRING),

However that seems to mess up the test. When doing a grep -v to exclude it from the test it still didn't work due to the width of columns.

@dveeden dveeden force-pushed the mysql__compression_alg__mariadb branch from ac3cc0b to 0f27db3 Compare July 14, 2023 13:20
@davidecoccia davidecoccia mentioned this pull request Jul 14, 2023
Closed
@dveeden
Copy link
Contributor Author

dveeden commented Sep 29, 2023

@akopytov is this ok or is anything else needed?

@dveeden
Copy link
Contributor Author

dveeden commented Nov 3, 2023

@akopytov could you see if this is ok to merge?

@dveeden dveeden closed this Nov 17, 2023
@akopytov akopytov reopened this Jul 28, 2024
@akopytov akopytov merged commit de18a03 into akopytov:master Jul 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building from source on Amazon Linux for ARM does not work after rel 1.0.20
2 participants
@dveeden @akopytov