feat: custom connection factory when using withSession #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Nov 26, 2024
| /** | ||
| * Provide a custom connectionFactory and an optional config path to load closeCallsExceeding from. | ||
| */ | ||
| def withSession[A](system: ActorSystem[_], connectionFactory: ConnectionFactory, configPath: Option[String])( |
There was a problem hiding this comment.
I don't think we should have configPath in this one. It's only used for closeCallsExceeding and we can instead take that from the default connectionFactoryConfigPath.
patriknw
reviewed
Nov 26, 2024
| @@ -37,7 +38,16 @@ object R2dbcSession { | |||
| fun: R2dbcSession => Future[A]): Future[A] = { | |||
| val connectionFactoryProvider = ConnectionFactoryProvider(system) | |||
| val connectionFactory = connectionFactoryProvider.connectionFactoryFor(connectionFactoryConfigPath) | |||
| val poolSettings = new ConnectionPoolSettings(system.settings.config.getConfig(connectionFactoryConfigPath)) | |||
| withSession(system, connectionFactory)(fun) | |||
There was a problem hiding this comment.
Here it should still use the poolSettings.closeCallsExceeding from the given connectionFactoryConfigPath
patriknw
reviewed
Nov 26, 2024
akka-projection-r2dbc/src/main/scala/akka/projection/r2dbc/scaladsl/R2dbcSession.scala
Outdated
Show resolved
Hide resolved
…ladsl/R2dbcSession.scala Co-authored-by: Patrik Nordwall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1254