Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support timestamp offset by slice for grpc projections #1181

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

pvlugter
Copy link
Contributor

Depends on akka/akka#32479 to be published first.

@pvlugter pvlugter marked this pull request as draft August 15, 2024 02:29
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvlugter pvlugter force-pushed the timestamp-offset-by-slice branch 2 times, most recently from ae61ab7 to 8856118 Compare August 19, 2024 03:51
@pvlugter
Copy link
Contributor Author

pvlugter commented Aug 19, 2024

Looking to get a green build on published akka snapshot. Fine apart from native image test — either doesn't build with the akka snapshot (evicts dependency), or fails to build because of the + in the snapshot version. Just disabling the test for now, until akka release version is available.

@pvlugter pvlugter force-pushed the timestamp-offset-by-slice branch from 8856118 to ff8ea29 Compare August 20, 2024 22:58
@pvlugter pvlugter mentioned this pull request Aug 20, 2024
@pvlugter pvlugter force-pushed the timestamp-offset-by-slice branch from ff8ea29 to 05a1876 Compare August 21, 2024 22:25
@pvlugter pvlugter marked this pull request as ready for review August 21, 2024 22:40
@pvlugter pvlugter merged commit 98cccc2 into main Aug 22, 2024
22 checks passed
@pvlugter pvlugter deleted the timestamp-offset-by-slice branch August 22, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants