-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support timestamp offset by slice for grpc projections #1181
Conversation
akka-projection-grpc/src/main/protobuf/akka/projection/grpc/event_producer.proto
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
...ojection-grpc/src/main/scala/akka/projection/grpc/internal/ProtobufProtocolConversions.scala
Outdated
Show resolved
Hide resolved
...ojection-grpc/src/main/scala/akka/projection/grpc/internal/ProtobufProtocolConversions.scala
Show resolved
Hide resolved
akka-projection-grpc/src/main/protobuf/akka/projection/grpc/event_producer.proto
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ae61ab7
to
8856118
Compare
Looking to get a green build on published akka snapshot. Fine apart from native image test — either doesn't build with the akka snapshot (evicts dependency), or fails to build because of the |
8856118
to
ff8ea29
Compare
ff8ea29
to
05a1876
Compare
Depends on akka/akka#32479 to be published first.