chore: Remove ApiMayChange on Projection and RES over gRPC #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
commented
Jun 13, 2024
| @@ -556,7 +556,7 @@ private[projection] class R2dbcOffsetStore( | |||
| val seqNr = recordWithOffset.record.seqNr | |||
| val currentState = getState() | |||
|
|
|||
| val duplicate = getState().isDuplicate(recordWithOffset.record) | |||
| val duplicate = currentState.isDuplicate(recordWithOffset.record) | |||
There was a problem hiding this comment.
this is unrelated, small cleanup that I had lying around
johanandren
approved these changes
Jun 13, 2024
| @@ -592,7 +590,6 @@ object ConsumerFilter extends ExtensionId[ConsumerFilter] { | |||
|
|
|||
| } | |||
|
|
|||
| @ApiMayChange | |||
| class ConsumerFilter(system: ActorSystem[_]) extends Extension { | |||
There was a problem hiding this comment.
Should maybe be final since not meant for user extension
| @@ -83,7 +81,6 @@ object GrpcReadJournal { | |||
|
|
|||
| } | |||
|
|
|||
| @ApiMayChange | |||
| class GrpcReadJournal(delegate: scaladsl.GrpcReadJournal) | |||
There was a problem hiding this comment.
Final since public and not meant for extension
Comment on lines
18
to
19
| */ | ||
| @ApiMayChange | ||
| abstract class ReplicatedBehaviors[Command, Event, State] { |
There was a problem hiding this comment.
* Not for user extension
*/
@DoNotInherit
Both language versions, we implement it and hand it to the user who only uses it
| @@ -23,7 +22,6 @@ object Replica { | |||
|
|
|||
| } | |||
|
|
|||
| @ApiMayChange | |||
| trait Replica { | |||
There was a problem hiding this comment.
Suggested change
| trait Replica { | |
| /** | |
| * Not for user extension | |
| */ | |
| @DoNotInherit | |
| trait Replica { |
| @@ -19,7 +18,6 @@ import akka.stream.scaladsl.FlowWithContext | |||
| /** | |||
| * Factory/function for creating the projection where offsets are kept track of for the replication streams | |||
| */ | |||
| @ApiMayChange | |||
| trait ReplicationProjectionProvider { | |||
There was a problem hiding this comment.
Suggested change
| trait ReplicationProjectionProvider { | |
| @FunctionalInterface | |
| trait ReplicationProjectionProvider { |
|
thanks, incorporated feedback |
johanandren
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.