Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Reference docs for edge Replicated Event Sourcing #1080

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Dec 4, 2023

No description provided.

@@ -192,26 +218,24 @@ By default, events from all Replicated Event Sourced entities are replicated.
The same kind of filters as described in @ref:[Akka Projection gRPC Filters](grpc.md#filters) can be used for
Replicated Event Sourcing.

The producer defined filter:
The producer filter is defined with `withProducerFilter` or `withProducerFilterTopicExpression` in @apidoc[ReplicationSettings]:

Scala
: @@snip [ShoppingCart.scala](/samples/replicated/shopping-cart-service-scala/src/main/scala/shopping/cart/ShoppingCart.scala) { #init-producerFilter }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sample should be updated to use withProducerFilter, but need a release first

it would typically only define one or a few cloud replicas that it will connect to. A gRPC server is not needed on the
edge side, because there are no incoming connections.

On the edge side you start with `Replication.grpcEdgeReplication`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe deserves a snippet in the sample

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added doc snippets in sample, and a few other improvements ba7ac8f

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* ReplicationSettings withProducerFilter
* grpcEdgeReplication
* rewrite ReplicationSettingsSpec to use ScalaTestWithActorTestKit
@patriknw patriknw force-pushed the wip-res-edge-docs-patriknw branch from fecbc94 to ba7ac8f Compare December 5, 2023 07:01
@patriknw patriknw merged commit 3a5c3b3 into main Dec 5, 2023
21 checks passed
@patriknw patriknw deleted the wip-res-edge-docs-patriknw branch December 5, 2023 08:27
@patriknw patriknw added this to the 1.5.1 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants