Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: More detailed error message for invalid replica config #1067

Merged
merged 1 commit into from
Nov 9, 2023
Merged

chore: More detailed error message for invalid replica config #1067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...ction-grpc/src/main/scala/akka/projection/grpc/replication/internal/ReplicationImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,11 @@ private[akka] object ReplicationImpl {
envelope.eventMetadata match {
case Some(replicatedEventMetadata: ReplicatedEventMetadata) =>
// skipping events originating from other replicas is handled by filtering but for good measure
require(replicatedEventMetadata.originReplica == remoteReplica.replicaId)
if (replicatedEventMetadata.originReplica != remoteReplica.replicaId)
throw new IllegalArgumentException(
"Expected replicated event from replica " +
s"[${remoteReplica.replicaId}] but was [${replicatedEventMetadata.originReplica}]. " +
"Verify your replication configuration, such as self-replica-id.")

val replicationId = ReplicationId.fromString(envelope.persistenceId)
val destinationReplicaId = replicationId.withReplica(settings.selfReplicaId)
Expand Down