Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Start from snapshot for drone push projection #1044

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

johanandren
Copy link
Member

@johanandren johanandren commented Oct 18, 2023

Depends on #1047 and event writer fix P is working on over in Akka
Depends on #1048

.snapshotWhen { (_, event, _) =>
event.isInstanceOf[CoarseGrainedLocationChanged]
}
// #startFromSnapshot
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag for every coarse grained so we always have such a starting point

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, don't care about history and just use the latest makes sense for this

@patriknw
Copy link
Member

I added eventsBySlicesStartingFromSnapshots in the other place.
I have verified that the sample works as expected with #1048 and akka/akka#32191

eventProducer.eventProducerSource.entityType,
0,
maxSlice),
// FIXME EventProducerSettings.EventProducerSource.startingFromSnapshots not used and no public accessor to pick it up from there, confusing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled this fixme in #1049

@patriknw
Copy link
Member

Need this in the java sample too, I can add that after lunch.

@patriknw patriknw force-pushed the wip-edge-sample-start-from-snapshots branch from 42898ac to 11dee03 Compare October 25, 2023 11:44
@patriknw patriknw marked this pull request as ready for review October 25, 2023 11:44
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanandren
Copy link
Member Author

Thanks for finishing it up.

Copy link
Member Author

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patriknw patriknw merged commit 3e6f058 into main Oct 25, 2023
19 checks passed
@patriknw patriknw deleted the wip-edge-sample-start-from-snapshots branch October 25, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants