Pre release 24.10 #871
Merged
Pre release 24.10 #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sebastian-alfers
commented
Oct 23, 2024
sebastian-alfers
commented
- bump akka to 2.10.0
- license date and version
- bump sbt-paradox-akka
- remove gitter
patriknw
reviewed
Oct 23, 2024
CONTRIBUTING.md
Outdated
| @@ -12,7 +12,7 @@ This is the process for committing code into master. | |||
| 6. After the review you should fix the issues (review comments, CI failures) by pushing a new commit for new review, iterating until the reviewers give their thumbs up and CI tests pass. | |||
| 7. If the branch merge conflicts with its target, rebase your branch onto the target branch. | |||
|
|
|||
| In case of questions about the contribution process or for discussion of specific issues please visit the [akka/dev gitter chat](https://gitter.im/akka/dev). | |||
| In case of questions about the contribution process or for discussion of specific issues please visit the [akka forum](https://discuss.lightbend.com/c/akka/). | |||
There was a problem hiding this comment.
shouldn't we use https://discuss.akka.io/
| @@ -22,7 +22,7 @@ object ProjectAutoPlugin extends AutoPlugin { | |||
| developers += Developer( | |||
| "contributors", | |||
| "Contributors", | |||
| "https://gitter.im/akka/dev", | |||
| "akka[email protected]", | |||
There was a problem hiding this comment.
do we have to have an email here?
There was a problem hiding this comment.
I just looked at this one: https://github.com/akka/akka/blob/main/project/Publish.scala#L44
johanandren
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.