Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete outside backtracking debug log #132

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

pvlugter
Copy link
Contributor

Now that we disable backtracking when far behind, this old debug log is not so useful — will log every offset in catch up mode. Removing it. Alternative would be to explicitly track when in catch up mode with disabled backtracking in the state, so we only log this when backtracking is enabled.

@pvlugter pvlugter requested a review from patriknw January 13, 2025 22:43
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw merged commit 26b21eb into main Jan 14, 2025
5 checks passed
@patriknw patriknw deleted the remove-outside-backtracking-debug branch January 14, 2025 08:28
@patriknw patriknw added this to the 2.0.5 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants