Skip to content

Commit

Permalink
Document usage of latest_decided in AuthorityDiscoveryApi
Browse files Browse the repository at this point in the history
  • Loading branch information
kayabaNerve committed Dec 24, 2023
1 parent 2b23252 commit fff8dcb
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions substrate/runtime/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,12 @@ sp_api::impl_runtime_apis! {
if network == NetworkId::Serai {
continue;
}
// Returning the latest-decided, not latest and active, means the active set
// may fail to peer find if there isn't sufficient overlap. If a large amount reboot,
// forcing some validators to successfully peer find in order for the threshold to become
// online again, this may cause a liveness failure.
//
// This is assumed not to matter in real life, yet an interesting note.
let participants =
ValidatorSets::participants_for_latest_decided_set(network)
.map_or(vec![], BoundedVec::into_inner);
Expand Down

0 comments on commit fff8dcb

Please sign in to comment.