Skip to content
This repository has been archived by the owner on Sep 18, 2020. It is now read-only.

Only update api if specifes the name #44

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

mgi166
Copy link

@mgi166 mgi166 commented Nov 8, 2015

The reason why I create this PR

Recently, updates aki017/slack-api-docs@1ac07b4 by aki017/slack-api-docs-generator.

But aki017/slack-ruby-gem does not follow the latest aki017/slack-api-docs. So if you execute rake api:update, creates too many diffs in one commit.

It's undesirable to revert api update if you failed.

I think that if rake api:update specifies api name, only update the api, so prevent the tragedy and you can more easily update aki017/slack-ruby-gem in stages

I hope that aki017/slack-ruby-gem follows latest slack api as soon as possible.

Usage

# No specifies the argument, update all.
$ rake api:update

# Specifies the api name, only updates the api.
$ rake 'api:update[channels]'

What do I ask

What do you think this policy? Please let me oponion.

@miguelperez
Copy link

This seems reasonable. @aki017 are you planning on updating the gem with the latest Slack API calls?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants