Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry Tables] e2e Test to make sure changing sort order in limited mode makes another request #488

Merged
merged 7 commits into from
Nov 5, 2024
Merged

[Telemetry Tables] e2e Test to make sure changing sort order in limited mode makes another request #488

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6f95af9
adding test for sort order re request in limited mode
jvigliotta Nov 1, 2024
c8b4613
updating locator
jvigliotta Nov 1, 2024
47e9a11
added suggestion, fixed some lint errors
jvigliotta Nov 1, 2024
d94219f
removing unnecessary line
jvigliotta Nov 4, 2024
35ca8ee
Merge branch 'master' into mct-7876
jvigliotta Nov 5, 2024
b8320d6
modifying how we navigate overall in this test suite
jvigliotta Nov 5, 2024
c4edf3e
Merge branch 'mct-7876' of https://github.com/akhenry/openmct-yamcs i…
jvigliotta Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions tests/e2e/yamcs/telemetryTables.e2e.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,30 @@ test.describe("Telemetry Tables tests @yamcs", () => {
await expect(page.getByRole('button', { name: 'SHOW LIMITED' })).toBeVisible();
});

test('Changing sort order in limited mode triggers a new request', async ({ page }) => {
// Set up request promise for an events request in descending order
const eventRequestOrderDescending = page.waitForRequest(/.*\/api\/.*\/events.*order=desc$/);

// Navigate to the Events table
await page.getByLabel('Navigate to Events yamcs.').click();
Copy link
Collaborator

@unlikelyzero unlikelyzero Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works, but the following would be better

await page.goto(./events, { waitUntil: 'networkidle' })

await page.waitForLoadState('networkidle');
jvigliotta marked this conversation as resolved.
Show resolved Hide resolved

// Wait for and verify that the request was made
await expect(eventRequestOrderDescending).resolves.toBeTruthy();

// Assert that the 'SHOW UNLIMITED' button is visible (we are in limited mode)
await expect(page.getByRole('button', { name: 'SHOW UNLIMITED' })).toBeVisible();

// Set up request promise before clicking to change sort order
const eventRequestOrderAscending = page.waitForRequest(/.*\/api\/.*\/events.*order=asc$/);

// flip sort order
await page.locator('thead div').filter({ hasText: 'Generation Time' }).click();

// Wait for and verify that the request was made
await expect(eventRequestOrderAscending).resolves.toBeTruthy();
});

test('Telemetry tables are sorted in desc order correctly', async ({ page }) => {
await setRealTimeMode(page);

Expand Down
Loading