Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VIPERGC-574): update fault provider for new YAMCS API and provide shelve durations #481

Merged
merged 18 commits into from
Oct 1, 2024

Conversation

ozyx
Copy link
Collaborator

@ozyx ozyx commented Sep 19, 2024

Closes VIPERGC-574

Describe your changes:

  • Updates the openmct-yamcs fault provider to match the API changes from YAMCS, fixing acknowledges and indefinite shelving of faults.
  • Adds e2e tests that use and mock real yamcs network traffic to test the various fault actions
  • Adds a getShelveDuration() method to allow openmct-yamcs fault provider to specify its own shelve durations.

NOTE: nasa/openmct#7849 must be merged first

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx force-pushed the vipergc-574 branch 2 times, most recently from 81e7ae9 to 28f38d8 Compare September 25, 2024 16:56
@ozyx ozyx added this to the Target:4.1.0 milestone Sep 25, 2024
@ozyx ozyx added the type:bug Something isn't working label Sep 25, 2024
@ozyx ozyx marked this pull request as ready for review September 25, 2024 17:01
@ozyx
Copy link
Collaborator Author

ozyx commented Sep 25, 2024

nasa/openmct#7849 needs to be merged before tests pass here

@akhenry akhenry requested review from shefalijoshi and removed request for scottbell and unlikelyzero September 30, 2024 19:23
Copy link
Collaborator

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Nice work!

src/providers/fault-mgmt-providers/utils.js Show resolved Hide resolved
src/openmct-yamcs.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@akhenry akhenry removed their request for review October 1, 2024 17:02
- this is so we can avoid binding to 0.0.0.0 in the dev server
@ozyx ozyx merged commit 67fac94 into master Oct 1, 2024
9 checks passed
@ozyx ozyx deleted the vipergc-574 branch October 1, 2024 23:56
@akhenry akhenry modified the milestones: Target:4.1.0, build9-rc11 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants