Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New default display and related functionality #478

Merged
merged 10 commits into from
Nov 1, 2024
Merged

New default display and related functionality #478

merged 10 commits into from
Nov 1, 2024

Conversation

charlesh88
Copy link
Collaborator

@charlesh88 charlesh88 commented Sep 11, 2024

Describe your changes:

  • Example Flexible Layout display loads by default at application start.
  • Illustrates multiple examples of Open MCT views including conditionals, conditional styling, Gauges, LAD Tables, Tab views and nested layouts.
    - Updated README to include note about alternate build command, a workaround as noted in Issue with YAMCS quickstart example #427.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@charlesh88 charlesh88 added the type:enhancement New feature or request label Sep 11, 2024
@charlesh88
Copy link
Collaborator Author

charlesh88 commented Sep 11, 2024

Testing Notes

No original issue for this (?) so testing notes here.

  1. Follow all steps to setup the openmct-yamcs plugin, including setting up the yamcs-quickstart project.
  2. Run both projects in terminal.
  3. Go to the URL for openmct-yamcs: by default, http://localhost:9000.
  4. Verify that Open MCT loads without console errors. The Time Conductor should be Real-time and using normal default values.
  5. Verify that the default display is shown. Click through the Tabs view in the display and verify that screens appear as shown in the reference section below.

Reference

Screenshot 2024-09-12 at 10 40 39 AM
Screenshot 2024-09-12 at 10 40 45 AM
Screenshot 2024-09-12 at 10 40 50 AM
Screenshot 2024-09-12 at 10 40 55 AM

Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's write a test for this when you have a chance

@davetsay
Copy link
Collaborator

@jvigliotta to write a test. @akhenry ready for review

@akhenry
Copy link
Owner

akhenry commented Sep 24, 2024

@unlikelyzero To describe tests needed here
@jvigliotta To remove comment about npm build and master.

@unlikelyzero unlikelyzero added this to the Target:4.1.0 milestone Oct 2, 2024
@unlikelyzero
Copy link
Collaborator

We need tests:

  • Verify display is loaded without console errors
  • Verify display components are visible

@ozyx ozyx self-requested a review October 29, 2024 17:53
@ozyx ozyx merged commit 433e720 into master Nov 1, 2024
9 checks passed
@ozyx ozyx deleted the default-display branch November 1, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants